Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle tooling to support JDK-22 #220

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

Achal1607
Copy link
Member

@Achal1607 Achal1607 commented Jul 31, 2024

Backporting NB-23 patch for upgrading Gradle to support JDK-22
apache/netbeans#7583

closes #190

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 31, 2024
sid-srini
sid-srini previously approved these changes Jul 31, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Awaiting BA before merge.

@lahodaj
Copy link
Member

lahodaj commented Aug 6, 2024

Should the patch also be enrolled in build.xml?

@Achal1607
Copy link
Member Author

Should the patch also be enrolled in build.xml?

Oh I completely forgot to do that.
Thanks for reminding

@sid-srini
Copy link
Member

Awaiting BA before merge.

BA received. Merge may be done once other reviews are approved.

@sid-srini sid-srini self-requested a review August 7, 2024 09:31
@Achal1607 Achal1607 merged commit 78ba888 into oracle:main Aug 7, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 22.1.2 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong version of Gradle used
3 participants